linux-kernel - Re: [PATCH] pstore: fix printk format warning

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Fri, 3 Aug 2012 18:35:36 -0700
From:	Kees Cook <keescook@...omium.org>
To:	Randy Dunlap <rdunlap@...otime.net>
Cc:	Anton Vorontsov <cbouatmailru@...il.com>,
	Linus Torvalds <torvalds@...ux-foundation.org>,
	Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
	Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
	Tony Luck <tony.luck@...el.com>,
	Colin Cross <ccross@...roid.com>
Subject: Re: [PATCH] pstore: fix printk format warning

On Fri, Aug 3, 2012 at 6:32 PM, Randy Dunlap <rdunlap@...otime.net> wrote:
> On 08/03/2012 06:15 PM, Anton Vorontsov wrote:
>
>> On Fri, Aug 03, 2012 at 05:02:48PM -0700, Randy Dunlap wrote:
>>> From: Randy Dunlap <rdunlap@...otime.net>
>>>
>>> Fix printk format warning (on i386) in pstore:
>>>
>>> fs/pstore/ram.c:409:3: warning: format '%lu' expects type 'long unsigned int', but argument 2 has type 'size_t'
>>>
>>> Signed-off-by: Randy Dunlap <rdunlap@...otime.net>
>>> Acked-by: Kees Cook <keescook@...omium.org>
>>> Cc: Anton Vorontsov <anton.vorontsov@...aro.org>
>>> ---
>>> I posted this patch on June 15 and July 23 but it has not been
>>> merged anywhere afaict, so I'm sending it directly to the man.
>>
>> (I believe it's the first time I see that patch.)
>
> That's quite possible.  When Kees acked it, he advised
> me to send it to GregKH, which I did, to no avail.
>
>
>> Btw, I see no maintainers for the pstore, and it surely no longer
>> belongs to staging. Tony, I can send patches to you, or I can create
>> a git tree (actually, I already had it for my own convenience).. So
>> how about the following patch?
>
> Thanks for adding a MAINTAINERS entry for it.
>
>> Kees, Colin, as you're also pstore authors, I assume you're interested
>> in reviewing/[n]acking any possible changes, so I also added you to
>> the M: entries, is that OK?

Cool with me; thanks!

-Kees

-- 
Kees Cook
Chrome OS Security
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/