linux-kernel - Re: [PATCH] time: Fix adjustment cleanup bug in timekeeping

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <201208050950.IHH64070.QMLFSHOFFVOtOJ@I-love.SAKURA.ne.jp>
Date:	Sun, 5 Aug 2012 09:50:18 +0900
From:	Tetsuo Handa <penguin-kernel@...ove.SAKURA.ne.jp>
To:	mingo@...nel.org
Cc:	john.stultz@...aro.org, tglx@...utronix.de, a.p.zijlstra@...llo.nl,
	richardcochran@...il.com, prarit@...hat.com,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH] time: Fix adjustment cleanup bug in timekeeping_adjust()

Ingo Molnar wrote:
> > Bisected to 2a8c0883 "time: Move xtime_nsec adjustment 
> > underflow handling timekeeping_adjust".
> > 
> > Would you check?
> 
> probably caused by this stray return in timekeeping_adjust():
> 
>         } else
>                 return;
> 
> which should really be a proper goto - like the (totally 
> untested!) patch below.
> 
> Does this fix the bug for you?
> 
> Thanks,
> 
> 	Ingo
> 
Yes, this fixed the bug.

Thank you.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/