linux-kernel - Re: [PATCH] module: Fix compile error for ref_module when CONFIG

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <87vcgwzwsj.fsf@rustcorp.com.au>
Date:	Mon, 06 Aug 2012 10:00:52 +0930
From:	Rusty Russell <rusty@...tcorp.com.au>
To:	Barbaros Tokaoğlu <barbarost@...il.com>
Cc:	linux-kernel@...r.kernel.org
Subject: Re: [PATCH] module: Fix compile error for ref_module when CONFIG_MODULES is not set

On Wed, 1 Aug 2012 20:57:07 +0300, Barbaros Tokaoğlu <barbarost@...il.com> wrote:
> ref_module function is not defined when CONFIG_MODULES is not set thus
> it causes compile error when a module which is set to be built-in uses it.
> This patch defines a dummy ref_module function when CONFIG_MODULES
> is not set.
> 
> Signed-off-by: Barbaros Tokaoğlu <barbarost@...il.com>

Hi Barbaros,

        It's usually a good idea to paste the error message into the
commit message for compile fixes: it helps people googling the problem.

In this case, it's particularly important, because I can't find any
users of ref_module() outside module.c itself: it's only exported for
ksplice to use.

Cheers,
Rusty.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/