linux-kernel - Re: [PATCH 1/4] arm/dts: omap5-evm: Add I2C support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20120806083843.GA17612@arwen.pp.htv.fi>
Date:	Mon, 6 Aug 2012 11:38:45 +0300
From:	Felipe Balbi <balbi@...com>
To:	Sergei Shtylyov <sshtylyov@...sta.com>
Cc:	Sourav Poddar <sourav.poddar@...com>, linux-kernel@...r.kernel.org,
	devicetree-discuss@...ts.ozlabs.org, linux-omap@...r.kernel.org,
	linux-arm-kernel@...ts.infradead.org,
	Santosh Shilimkar <santosh.shilimkar@...com>,
	Benoit Cousson <b-cousson@...com>, Felipe Balbi <balbi@...com>
Subject: Re: [PATCH 1/4] arm/dts: omap5-evm: Add I2C support

Hi,

On Fri, Aug 03, 2012 at 09:22:19PM +0400, Sergei Shtylyov wrote:
> Hello.
> 
> On 08/03/2012 04:38 PM, Sourav Poddar wrote:
> 
> > Add I2C data node in omap5 device tree file.
> 
> > Tested on omap5430 sdp.
> 
> > Cc: Benoit Cousson <b-cousson@...com>
> > Cc: Felipe Balbi <balbi@...com>
> > Cc: Santosh Shilimkar <santosh.shilimkar@...com>
> > Acked-by: Felipe Balbi <balbi@...com>
> > Signed-off-by: Sourav Poddar <sourav.poddar@...com>
> > ---
> >  arch/arm/boot/dts/omap5.dtsi |   35 +++++++++++++++++++++++++++++++++++
> >  1 files changed, 35 insertions(+), 0 deletions(-)
> 
> > diff --git a/arch/arm/boot/dts/omap5.dtsi b/arch/arm/boot/dts/omap5.dtsi
> > index 57e5270..6b68dfe 100644
> > --- a/arch/arm/boot/dts/omap5.dtsi
> > +++ b/arch/arm/boot/dts/omap5.dtsi
> > @@ -145,6 +145,41 @@
> >  			#interrupt-cells = <1>;
> >  		};
> >  
> > +		i2c1: i2c@...70000 {
> > +			compatible = "ti,omap4-i2c";
> > +			#address-cells = <1>;
> > +			#size-cells = <0>;
> > +			ti,hwmods = "i2c1";
> 
>    Address postfix in the node name and no "reg" property?

that's because of the ti,hwmods attribute. OMAP is still not entirely
converted to DT and there's this weird ti,hwmods attribute. OMAP's hwmod
framework will fill up register addresses, irqs, etc when the device is
created. Oh well...

-- 
balbi

Download attachment "signature.asc" of type "application/pgp-signature" (837 bytes)