linux-kernel - Re: [PATCH 3/3 v2] [media] sta2x11_vip: convert to videobuf2 and control framework

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <2930909.DTsasJxcLr@harkonnen>
Date:	Mon, 06 Aug 2012 10:55:06 +0200
From:	Federico Vaga <federico.vaga@...il.com>
To:	Hans Verkuil <hverkuil@...all.nl>
Cc:	Mauro Carvalho Chehab <mchehab@...radead.org>,
	Pawel Osciak <pawel@...iak.com>,
	Marek Szyprowski <m.szyprowski@...sung.com>,
	Hans Verkuil <hans.verkuil@...co.com>,
	Giancarlo Asnaghi <giancarlo.asnaghi@...com>,
	linux-media@...r.kernel.org, linux-kernel@...r.kernel.org,
	Jonathan Corbet <corbet@....net>
Subject: Re: [PATCH 3/3 v2] [media] sta2x11_vip: convert to videobuf2 and control framework

> > +	vip->video_dev->flags |= V4L2_FL_USES_V4L2_FH |
> > V4L2_FL_USE_FH_PRIO;
> Been there, done that :-)
> 
> V4L2_FL_USE_FH_PRIO is a bit number, not a bit mask. Use set_bit
> instead:
> 
> 	set_bit(V4L2_FL_USE_FH_PRIO, &vip->video_dev->flags);
> 
> No need to set V4L2_FL_USES_V4L2_FH, BTW. That will be set
> automatically as soon as v4l2_fh_open is called.

I saw "unsigned long flags;" in the header but without reading the 
comment :) Thank you. I will test it in these days but I think it's all 
done.

-- 
Federico Vaga
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/