linux-kernel - Re: [Patch] string: do not export memweight() to userspace

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAC5umyixTGiy-1+8G5m5pULA4X38=s=DE5XovMuR9M0zNFSjmg@mail.gmail.com>
Date:	Mon, 6 Aug 2012 21:40:47 +0900
From:	Akinobu Mita <akinobu.mita@...il.com>
To:	Cong Wang <amwang@...hat.com>
Cc:	linux-kernel@...r.kernel.org,
	Andrew Morton <akpm@...ux-foundation.org>,
	WANG Cong <xiyou.wangcong@...il.com>,
	Joern Engel <joern@...fs.org>,
	Christoph Lameter <cl@...ux-foundation.org>,
	Pekka Enberg <penberg@...nel.org>
Subject: Re: [Patch] string: do not export memweight() to userspace

2012/8/6 Cong Wang <amwang@...hat.com>:
> From: WANG Cong <xiyou.wangcong@...il.com>
>
> This patch fixes the following warning:
>
> usr/include/linux/string.h:8: userspace cannot reference function or variable defined in the kernel

Thanks for finding this problem.
Looks good to me.

> Cc: Akinobu Mita <akinobu.mita@...il.com>
> Signed-off-by: WANG Cong <xiyou.wangcong@...il.com>
>
> ---
> diff --git a/include/linux/string.h b/include/linux/string.h
> index ffe0442..b917881 100644
> --- a/include/linux/string.h
> +++ b/include/linux/string.h
> @@ -144,8 +144,8 @@ static inline bool strstarts(const char *str, const char *prefix)
>  {
>         return strncmp(str, prefix, strlen(prefix)) == 0;
>  }
> -#endif
>
>  extern size_t memweight(const void *ptr, size_t bytes);
>
> +#endif /* __KERNEL__ */
>  #endif /* _LINUX_STRING_H_ */
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/