linux-kernel - Re: [PATCH 1/5] staging/csr: clean coding style in uf_start

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Message-ID: <20120806135556.GA9956@mwanda>
Date:	Mon, 6 Aug 2012 16:55:56 +0300
From:	Dan Carpenter <dan.carpenter@...cle.com>
To:	Devendra Naga <develkernel412222@...il.com>
Cc:	Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
	devel@...verdev.osuosl.org, linux-kernel@...r.kernel.org,
	Veli-Pekka Peltola <veli-pekka.peltola@...egiga.com>,
	Mikko Virkkilä <mikko.virkkila@...egiga.com>,
	Riku Mettälä <riku.mettala@...egiga.com>,
	Lauri Hintsala <Lauri.Hintsala@...egiga.com>
Subject: Re: [PATCH 1/5] staging/csr: clean coding style in uf_start_thread

This was sent encoded as base64 which is awkward.

On Sat, Aug 04, 2012 at 01:01:38PM +0545, Devendra Naga wrote:
> -    } else {
> -        priv->bh_thread.prio = DEFAULT_PRIO;
> -    }
> +	} else
> +		priv->bh_thread.prio = DEFAULT_PRIO;

Probably it's not worth resending if this is the only complaint, but
actually the original had that braces correct.  If either side of
the if else statement gets uses curly braces then both sides should
use them.

regards,
dan carpenter
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/