linux-kernel - Re: [PATCH] drivers/media/video/mx2_emmaprp.c: use devm_kzalloc and devm_clk

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20120806215320.21253wg8t8q1evok@webmail.lip6.fr>
Date:	Mon, 06 Aug 2012 21:53:20 +0200
From:	Julia.Lawall@...6.fr
To:	Lars-Peter Clausen <lars@...afoo.de>
Cc:	Dan Carpenter <dan.carpenter@...cle.com>,
	Julia Lawall <Julia.Lawall@...6.fr>,
	Mauro Carvalho Chehab <mchehab@...radead.org>,
	kernel-janitors@...r.kernel.org, linux-media@...r.kernel.org,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH] drivers/media/video/mx2_emmaprp.c: use devm_kzalloc
 and devm_clk_get

Quoting Lars-Peter Clausen <lars@...afoo.de>:

> On 08/06/2012 04:26 PM, Dan Carpenter wrote:
>> On Mon, Aug 06, 2012 at 05:23:23PM +0300, Dan Carpenter wrote:
>>> On Sat, Aug 04, 2012 at 08:23:27PM +0200, Julia Lawall wrote:
>>>> @@ -922,12 +920,7 @@ static int emmaprp_probe(struct  
>>>> platform_device *pdev)
>>>>
>>>>  	platform_set_drvdata(pdev, pcdev);
>>>>
>>>> -	if (devm_request_mem_region(&pdev->dev, res_emma->start,
>>>> -	    resource_size(res_emma), MEM2MEM_NAME) == NULL)
>>>> -		goto rel_vdev;
>>>> -
>>>> -	pcdev->base_emma = devm_ioremap(&pdev->dev, res_emma->start,
>>>> -					resource_size(res_emma));
>>>> +	pcdev->base_emma = devm_request_and_ioremap(&pdev->dev, res_emma);
>>>>  	if (!pcdev->base_emma)
>>>>  		goto rel_vdev;
>>>
>>> This was in the original code, but there is a "ret = -ENOMEM;"
>>> missing here, and again a couple lines down in the original code.
>>>
>>
>> Or should that be -EIO instead of -ENOMEM?  I'm not sure.
>
> -ENXIO is usually used in such a case.

Thanks for the feedback.  I won't be able to access my work machine  
until the end of the week, so I will fix it then.

julia



--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/