linux-kernel - Re: Subject: [PATCH] sched: add missing group change to qfq_change

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20120806.133103.173950447984896787.davem@davemloft.net>
Date:	Mon, 06 Aug 2012 13:31:03 -0700 (PDT)
From:	David Miller <davem@...emloft.net>
To:	paolo.valente@...more.it
Cc:	shemminger@...tta.com, jhs@...atatu.com, fchecconi@...il.com,
	rizzo@....unipi.it, netdev@...r.kernel.org,
	linux-kernel@...r.kernel.org
Subject: Re: Subject: [PATCH] sched: add missing group change to
 qfq_change_class

From: Paolo Valente <paolo.valente@...more.it>
Date: Sun, 05 Aug 2012 21:45:37 +0200

> To speed up operations, QFQ internally divides classes into
> groups. Which group a class belongs to depends on the ratio between
> the maximum packet length and the weight of the class. Unfortunately
> the function qfq_change_class lacks the steps for changing the group
> of a class when the ratio max_pkt_len/weight of the class changes.
> 
> For example, when the last of the following three commands is
> executed, the group of class 1:1 is not correctly changed:
> 
> tc disc add dev XXX root handle 1: qfq
> tc class add dev XXX parent 1: qfq classid 1:1 weight 1
> tc class change dev XXX parent 1: classid 1:1 qfq weight 4
> 
> Not changing the group of a class does not affect the long-term
> bandwidth guaranteed to the class, as the latter is independent of the
> maximum packet length, and correctly changes (only) if the weight of
> the class changes. In contrast, if the group of the class is not
> updated, the class is still guaranteed the short-term bandwidth and
> packet delay related to its old group, and not the guarantees that it
> should receive according to its new weight and/or maximum packet
> length. This may also break service guarantees for other classes.
> This patch adds the missing operations.
> 
> Signed-off-by: Paolo Valente <paolo.valente@...more.it>

Please provide clean Subject lines with patch submissions.

Also, this patch doesn't apply cleanly at all.  Email the patch
to yourself, and verify that you can in fact apply it to the
current networking GIT tree just as I will have to.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/