lists.openwall.net   lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  linux-hardening  linux-cve-announce  PHC 
Open Source and information security mailing list archives
 
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <CANN689GZDxCkz-01qnZYENWDJhezFf1f-Xgx0NoaxPf64Cz_GQ@mail.gmail.com>
Date:	Mon, 6 Aug 2012 14:20:14 -0700
From:	Michel Lespinasse <walken@...gle.com>
To:	Peter Zijlstra <peterz@...radead.org>
Cc:	riel@...hat.com, daniel.santos@...ox.com, aarcange@...hat.com,
	dwmw2@...radead.org, akpm@...ux-foundation.org, linux-mm@...ck.org,
	linux-kernel@...r.kernel.org, torvalds@...ux-foundation.org
Subject: Re: [PATCH v2 6/9] rbtree: low level optimizations in rb_erase()

On Mon, Aug 6, 2012 at 1:58 PM, Peter Zijlstra <peterz@...radead.org> wrote:
> On Mon, 2012-08-06 at 13:50 -0700, Michel Lespinasse wrote:
>> On Mon, Aug 6, 2012 at 7:21 AM, Peter Zijlstra <peterz@...radead.org> wrote:
>> > On Thu, 2012-08-02 at 15:34 -0700, Michel Lespinasse wrote:
>> >> +                       /* Case 3: node's successor is leftmost under its
>> >> +                        * right child subtree
>> >
>> > Hmm?
>>
>> Would 'leftmost under node's right child subtree' make more sense ?
>
> Nah, its the comment style discrepancy..
>
>  /*
>   * Case 3: ....

Gah, failed to notice that. Sending new patch (just the comment
changed) as a reply.

-- 
Michel "Walken" Lespinasse
A program is never fully debugged until the last user dies.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Powered by blists - more mailing lists

Powered by Openwall GNU/*/Linux Powered by OpenVZ