lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Tue, 07 Aug 2012 16:26:21 -0700 From: Kevin Hilman <khilman@...com> To: Len Brown <lenb@...nel.org> Cc: x86@...nel.org, linux-pm@...ts.linux-foundation.org, linux-kernel@...r.kernel.org, Jonas Bonn <jonas@...thpole.se>, Len Brown <len.brown@...el.com>, #@...l.linuxfoundation.org, Tony Luck <tony.luck@...el.com>, Mike Frysinger <vapier@...too.org>, Michal Simek <monstr@...str.eu>, David Howells <dhowells@...hat.com>, Mikael Starvik <starvik@...s.com>, Russell King <linux@....linux.org.uk>, "David S. Miller" <davem@...emloft.net>, linux-arm-kernel <linux-arm-kernel@...ts.infradead.org> Subject: Re: [linux-pm] [PATCH 4/4] PM: cleanup: stop mandating that platforms export (pm_idle)() + linux-arm-kernel Len Brown <lenb@...nel.org> writes: > From: Len Brown <len.brown@...el.com> > > (pm_idle)() was originally used on x86 to vector bewteen > ACPI and APM. With the advent of CPU_IDLE, that reason > for pm_idle to exist vanished. > > But x86 APM still scribbled on pm_idle from a module, > so pm_idle didn't go away. Worse, it was declared in pm.h, > and so it spread to other architectures as dead code. > > But today, APM no longer scribbles on pm_idle, so > x86 no longer requires pm_idle to be visible to modules, > or global at all. > > Here we remove pm_idle from pm.h, to stop the mandate > that all architectures define it. > > This deletes dead code from most architectures, > while some continue using their own internal pm_idle. > > At the end of the day, pm_idle... > becomes static in sh, was global > becomes static in x86, was EXPORT_SYMBOL > becomes as global in sparc, was EXPORT_SYMBOL > continues as static in m32r (no pm.h use there) > and is deleted from all other places in the kernel. > > Signed-off-by: Len Brown <len.brown@...el.com> > Cc: x86@...nel.org # x86 > Cc: Mike Frysinger <vapier@...too.org> # blackfin > Cc: Jonas Bonn <jonas@...thpole.se> # openrisc > Cc: Tony Luck <tony.luck@...el.com> # ia64 > Cc: David Howells <dhowells@...hat.com> # mn10300 > Cc: Mikael Starvik <starvik@...s.com> # cris > Cc: Michal Simek <monstr@...str.eu> # microblaze > Cc: Paul Mundt <lethal@...ux-sh.org> # sh > Cc: David S. Miller <davem@...emloft.net> # sparc > Cc: Russell King <linux@....linux.org.uk> # ARM > Cc: Rafael J. Wysocki <rjw@...k.pl> # PM > --- > arch/arm/kernel/process.c | 12 +++--------- Just looking at the ARM changes, it looks good to me. I tested it with and without CPUidle on my ARM-based TI/OMAP platforms (3430/n900, 4430/Panda) So for the arch/arm changes: Reviewed-by: Kevin Hilman <khilman@...com> Tested-by: Kevin Hilman <khilman@...com> Kevin -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists