lists.openwall.net   lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  linux-hardening  linux-cve-announce  PHC 
Open Source and information security mailing list archives
 
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Message-ID: <20120807044143.GA20339@lizard>
Date:	Mon, 6 Aug 2012 21:41:43 -0700
From:	Anton Vorontsov <cbouatmailru@...il.com>
To:	"Pallala, Ramakrishna" <ramakrishna.pallala@...el.com>
Cc:	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH v2] power_supply: Added support for power supply
 attribute sources

On Fri, Jul 27, 2012 at 06:28:31PM +0000, Pallala, Ramakrishna wrote:
[...]
> > > Signed-off-by: Ramakrishna Pallala <ramakrishna.pallala@...el.com>
> > > ---
> > [...]
> > > +extern int power_supply_attributes_register(struct device *parent,
> > > +				struct power_supply_attr_source *psy_attr);
> > 
> > Can you please show some user of the new calls? If I understand correctly,
> > you're going to call these from sensing (ADC, or some
> > other) drivers, which would be very very wrong thing to do.
> 
> I have submitted two patches, one on smb347_charger driver and one on max17042_battery driver
> to demonstrate the use of these API's.
> 
> [PATCH] smb347_charger: Add support for battery power supply attributes registration
> [PATCH] max17042_battery: add support for battery STATUS and CHARGE_TYPE

Yeah, I noticed them, I'll review the whole approach tomorrow.

Thanks!

-- 
Anton Vorontsov
Email: cbouatmailru@...il.com
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Powered by blists - more mailing lists

Powered by Openwall GNU/*/Linux Powered by OpenVZ