linux-kernel - Re: [PATCH 0/5] mfd: replace IORESOURCE_IO by IORESOURCE

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20120807113652.GA6282@flint.arm.linux.org.uk>
Date:	Tue, 7 Aug 2012 12:36:52 +0100
From:	Russell King <rmk@....linux.org.uk>
To:	Mark Brown <broonie@...nsource.wolfsonmicro.com>
Cc:	Haojian Zhuang <haojian.zhuang@...il.com>, sameo@...ux.intel.com,
	rpurdie@...ys.net, bryan.wu@...onical.com,
	linux-kernel@...r.kernel.org, Bergmann Arnd <arnd@...db.de>
Subject: Re: [PATCH 0/5] mfd: replace IORESOURCE_IO by IORESOURCE_MEM

On Tue, Aug 07, 2012 at 12:31:21PM +0100, Russell King wrote:
> On Tue, Aug 07, 2012 at 12:28:44PM +0100, Mark Brown wrote:
> > On Tue, Aug 07, 2012 at 12:13:31PM +0100, Russell King wrote:
> > > On Tue, Aug 07, 2012 at 11:38:51AM +0100, Mark Brown wrote:
> > 
> > > > If nothing else this seems much more suitable for stable and -rc (the
> > > > bug has been there since v3.4).
> > 
> > > There is no need for such hacks.
> > 
> > Please read the text you quoted above.
> 
> I did.
> 
> > > There's no need to botch this in any way what so ever, or invent some
> > > other solution only to have to (probably never) rework it.
> > 
> > The changes you're suggesting are extremely invasive for stable
> > especially given that we have a simple, driver local, fix available
> 
> *Rubbish*.

And, for those hard of thinking, I'll tell you exactly how invasive it
is.

1. You modify ioport.h to add the new type.
2. You change the mfd driver creating the resources to use the new type.
3. You change the mfd driver using the resources to call
   platform_resource_get() with the new type.
4. You get on with life.

Yes, it's really that damned simple.  Not invasive at all.

Mark, you're really making a mountain out of a bloody mole hill over this.

-- 
Russell King
 Linux kernel    2.6 ARM Linux   - http://www.arm.linux.org.uk/
 maintainer of:
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/