linux-kernel - Re: [PATCH] net:appletalk:ddp:fixed coding style issue again relating to

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Tue, 07 Aug 2012 09:10:07 -0700
From:	Joe Perches <joe@...ches.com>
To:	Jeffrin Jose <ahiliation@...oo.co.in>
Cc:	ebiederm@...ssion.com, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] net:appletalk:ddp:fixed coding style issue again
 relating to

On Tue, 2012-08-07 at 20:27 +0530, Jeffrin Jose wrote:
> / Is putting "rc = put_user(amount, (int __user *)argp);" on the same
> / indentation level as "amount = skb->len - sizeof(struct ddpehdr);"
> / really what you want to do?

> No. I was trying to place those lines at one
> indentation back from their current position.

If you are using checkpatch as a guide, run
"./scripts/checkpatch.pl -f --strict net/appletalk/ddp.c"
after you patch it and also correct any problems found in
the area you want to update too.

A second option is to use emacs with the proper linux
style indentation.

(See: Documentation/CodingStyle, Chapter 9: You've made a mess of it)

Another option is not to patch the file at all.

Also, don't submit multiple patches, resubmit 1 single patch
with all the appropriate corrections.

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/