linux-kernel - Re: rcu stalls seen with numasched

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20120807171859.GB3850@linux.vnet.ibm.com>
Date:	Tue, 7 Aug 2012 22:49:25 +0530
From:	Srikar Dronamraju <srikar@...ux.vnet.ibm.com>
To:	Peter Zijlstra <peterz@...radead.org>
Cc:	john stultz <johnstul@...ibm.com>,
	"Paul E. McKenney" <paulmck@...ux.vnet.ibm.com>,
	LKML <linux-kernel@...r.kernel.org>,
	Oleg Nesterov <oleg@...hat.com>
Subject: Re: rcu stalls seen with numasched_v2 patches applied.

* Peter Zijlstra <peterz@...radead.org> [2012-08-07 15:52:48]:

> On Tue, 2012-08-07 at 18:03 +0530, Srikar Dronamraju wrote:
> > Hi, 
> > 
> >  INFO: rcu_sched self-detected stall on CPU { 7}  (t=105182911 jiffies)
> >  Pid: 5173, comm: qpidd Tainted: G        W    3.5.0numasched_v2_020812+ #1
> >  Call Trace:
> >  <IRQ>  [<ffffffff810d4c7e>] rcu_check_callbacks+0x18e/0x650
> >  [<ffffffff81060918>] update_process_times+0x48/0x90
> >  [<ffffffff810a2a7e>] tick_sched_timer+0x6e/0xe0
> >  [<ffffffff810789a5>] __run_hrtimer+0x75/0x1a0
> >  [<ffffffff810a2a10>] ? tick_setup_sched_timer+0x100/0x100
> >  [<ffffffff810591cf>] ? __do_softirq+0x13f/0x240
> >  [<ffffffff81078d56>] hrtimer_interrupt+0xf6/0x240
> >  [<ffffffff814f0179>] smp_apic_timer_interrupt+0x69/0x99
> >  [<ffffffff814ef14a>] apic_timer_interrupt+0x6a/0x70
> >  <EOI>  [<ffffffff814e64b2>] ? _raw_spin_unlock_irqrestore+0x12/0x20
> >  [<ffffffff81082552>] sched_setnode+0x82/0xf0
> >  [<ffffffff8108bd38>] task_numa_work+0x1e8/0x240
> >  [<ffffffff81070c6c>] task_work_run+0x6c/0x80
> >  [<ffffffff81013984>] do_notify_resume+0x94/0xa0
> >  [<ffffffff814e6a6c>] retint_signal+0x48/0x8c
> 
> I haven't seen anything like that (obviously), but the one thing you can
> try is undo the optimization Oleg suggested and use a separate
> callback_head for the task_work and not reuse task_struct::rcu.
> 

Are you referring to this the commit 158e1645e (trim task_work: get rid of hlist)

I am also able to reproduce this on another 8 node machine too.

Just to update, I had to revert commit: b9403130a5  sched/cleanups: Add
load balance cpumask pointer to 'struct lb_env' so that your patches
apply cleanly. (I dont think this should have caused any problem.. but)

-- 
Thanks and Regards
Srikar

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/