lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Wed, 8 Aug 2012 08:11:02 +0200
From: Thierry Reding <thierry.reding@...onic-design.de>
To: Kukjin Kim <kgene.kim@...sung.com>
Cc: 'Tushar Behera' <tushar.behera@...aro.org>,
linux-samsung-soc@...r.kernel.org, linux-kernel@...r.kernel.org,
s.hauer@...gutronix.de, patches@...aro.org
Subject: Re: [PATCH] ARM: SAMSUNG: Fix compilation error with
s3c2410_defconfig
On Wed, Aug 08, 2012 at 09:54:13AM +0900, Kukjin Kim wrote:
> diff --git a/arch/arm/plat-samsung/Kconfig b/arch/arm/plat-samsung/Kconfig
> index 7aca31c..dcdfb77 100644
> --- a/arch/arm/plat-samsung/Kconfig
> +++ b/arch/arm/plat-samsung/Kconfig
> @@ -403,7 +403,7 @@ config S5P_DEV_USB_EHCI
>
> config S3C24XX_PWM
> bool "PWM device support"
> - select HAVE_PWM
> + select PWM
> help
> Support for exporting the PWM timer blocks via the pwm device
> system
You could add
select PWM_SAMSUNG
here to side-step the issue below.
> diff --git a/drivers/pwm/Kconfig b/drivers/pwm/Kconfig
> index 8fc3808..34c8ec1 100644
> --- a/drivers/pwm/Kconfig
> +++ b/drivers/pwm/Kconfig
> @@ -59,7 +59,7 @@ config PWM_PXA
>
> config PWM_SAMSUNG
> tristate "Samsung pwm support"
> - depends on PLAT_SAMSUNG
> + def_bool PLAT_SAMSUNG
tristate and def_bool conflict, don't they? I think the easiest way to
solve this problem would be to add a default line, like so:
default PLAT_SAMSUNG
I've checked this with a s3c2410_defconfig and this causes PWM_SAMSUNG
to be selected =y, which I guess is what you want.
Thierry
Content of type "application/pgp-signature" skipped
Powered by blists - more mailing lists