linux-kernel - Re: [PATCH v2] Bluetooth: Another vendor specific ID for BCM20702A0 [0a5c:21f1]

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Wed, 08 Aug 2012 10:37:57 +0200
From:	Michal Marek <mmarek@...e.cz>
To:	Gustavo Padovan <gustavo@...ovan.org>,
	linux-bluetooth@...r.kernel.org, marcel@...tmann.org,
	linux-kernel@...r.kernel.org, John Hommel <john.hommel@...com>
Subject: Re: [PATCH v2] Bluetooth: Another vendor specific ID for BCM20702A0
 [0a5c:21f1]

On 6.8.2012 20:40, Gustavo Padovan wrote:
> Author: Gustavo Padovan <gustavo.padovan@...labora.co.uk>
> Date:   Mon Aug 6 15:36:49 2012 -0300
> 
>     Bluetooth: Use USB_VENDOR_AND_INTERFACE_INFO() for Broadcom devices
>     
>     Many Broadcom devices has a vendor specific devices class, with this rule
>     we match all existent and future controllers with this behavior.
>     
>     Signed-off-by: Gustavo Padovan <gustavo.padovan@...labora.co.uk>
> 
> diff --git a/drivers/bluetooth/btusb.c b/drivers/bluetooth/btusb.c
> index cef3bac..504231e 100644
> --- a/drivers/bluetooth/btusb.c
> +++ b/drivers/bluetooth/btusb.c
> @@ -104,6 +104,9 @@ static struct usb_device_id btusb_table[] = {
>         /* Foxconn - Hon Hai */
>         { USB_DEVICE(0x0489, 0xe033) },
>  
> +       /*Broadcom devices with vendor specific id */
> +       { USB_VENDOR_AND_INTERFACE_INFO(0x0a5c, 0xff, 0x01, 0x01) },

Hi Gustavo,

Yes, this works. Well, I don't posses the card personally, but a helpful
person at HP confirmed that the btusb driver with this patch works with
the new card. So you can add

  Tested-by: John Hommel <john.hommel@...com>

BTW, the following ID can also be removed after adding the above match:

	{ USB_DEVICE(0x0a5c, 0x21e1) },
	{ USB_DEVICE(0x0a5c, 0x21e3) },
	{ USB_DEVICE(0x0a5c, 0x21e6) },
	{ USB_DEVICE(0x0a5c, 0x21e8) },
	{ USB_DEVICE(0x0a5c, 0x21f3) },

Thanks,
Michal
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/