[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Date: Wed, 08 Aug 2012 11:08:54 +0900
From: Kukjin Kim <kgene.kim@...sung.com>
To: 'Arnd Bergmann' <arnd@...db.de>,
'Dongjin Kim' <Dongjin.Kim@...eeyamobility.net>
Cc: 'Dongjin Kim' <tobetter@...il.com>,
'Russell King' <linux@....linux.org.uk>,
'Thomas Abraham' <thomas.abraham@...aro.org>,
'Grant Likely' <grant.likely@...retlab.ca>,
linux-arm-kernel@...ts.infradead.org, linux-kernel@...r.kernel.org
Subject: RE: ȸ½Å: [PATCH 2/4] arm/dts: exynos4: Add DTS files derived from common Exynos4
Arnd Bergmann wrote:
>
> On Tuesday 07 August 2012, Dongjin Kim wrote:
> > Hi,
> >
> > I didn't use -M and I couldn't see any difference with the it.
> > Did I make something wrong on that patch?
>
> No, I think it's just git being less smart about file moves than I was
> hoping
> for. It might do the right thing if you do the patch in two steps:
>
Yeah, in this case, git does not work just as we expected :-(
> 1. rename exynos4210.dtsi to exynos4.dtsi and add a one-line
> exynos4210.dtsi
> file that just includes exynos4.dtsi.
>
> 2. do all the changes for moving contents back from exynos4.dtsi into
> exynos4210.dtsi and exynos4412.dtsi.
>
> Not sure if it's worth it though.
Hehehe, but I did with separated commit as per your comment and it was ok,
then squashed, same...uhm...I think, we don't need to keep two commits
here...
> Your version is probably good enough
> if there are no tools to do a better job automatically.
>
I agree with Arnd's opinion and I will review in detail soon.
Thanks.
Best regards,
Kgene.
--
Kukjin Kim <kgene.kim@...sung.com>, Senior Engineer,
SW Solution Development Team, Samsung Electronics Co., Ltd.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists