linux-kernel - Re: [SCSI] qla4xxx: support iscsiadm session mgmt

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Wed, 8 Aug 2012 19:57:12 +0300
From:	Dan Carpenter <dan.carpenter@...cle.com>
To:	Mike Christie <michaelc@...wisc.edu>
Cc:	manish.rangankar@...gic.com, open-iscsi@...glegroups.com,
	linux-kernel@...r.kernel.org
Subject: Re: [SCSI] qla4xxx: support iscsiadm session mgmt

On Wed, Aug 08, 2012 at 10:35:44AM -0500, Mike Christie wrote:
> On 08/08/2012 10:00 AM, Dan Carpenter wrote:
> > I never heard back on this.  This buffer overflow is still present
> > in the current code.
> > 
> 
> Qlogic just sent a patch yesterday.
> http://marc.info/?l=linux-scsi&m=134434199930938&w=2

Ah, good.

It seems like qla4xxx_ep_connect() should take a pointer to struct
sockaddr_storage and also dst_addr in qla4xxx_get_ep_fwdb() should
be changed as well.  As in:

 static struct iscsi_endpoint *
-qla4xxx_ep_connect(struct Scsi_Host *shost, struct sockaddr *dst_addr,
+qla4xxx_ep_connect(struct Scsi_Host *shost, struct sockaddr_storage *dst_addr,
                    int non_blocking)

regards,
dan carpenter
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/