linux-kernel - Re: [PATCH 8/8] ARM: vt8500: gpio: Devicetree support for arch-vt8500

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <201208081917.19111.arnd@arndb.de>
Date:	Wed, 8 Aug 2012 19:17:18 +0000
From:	Arnd Bergmann <arnd@...db.de>
To:	Stephen Warren <swarren@...dotorg.org>
Cc:	Tony Prisk <linux@...sktech.co.nz>,
	vt8500-wm8505-linux-kernel@...glegroups.com,
	Russell King <linux@....linux.org.uk>,
	Alessandro Zummo <a.zummo@...ertech.it>,
	Grant Likely <grant.likely@...retlab.ca>,
	Rob Herring <rob.herring@...xeda.com>,
	Alan Cox <alan@...ux.intel.com>,
	"Greg Kroah-Hartman" <gregkh@...uxfoundation.org>,
	Alan Stern <stern@...land.harvard.edu>,
	Hauke Mehrtens <hauke@...ke-m.de>, Felipe Balbi <balbi@...com>,
	Neil Zhang <zhangwm@...vell.com>,
	Florian Tobias Schandinat <FlorianSchandinat@....de>,
	Rob Landley <rob@...dley.net>,
	Mark Brown <broonie@...nsource.wolfsonmicro.com>,
	Stephen Warren <swarren@...dia.com>,
	Eric Andersson <eric.andersson@...xphere.com>,
	Linus Walleij <linus.walleij@...ricsson.com>,
	linux-arm-kernel@...ts.infradead.org, linux-kernel@...r.kernel.org,
	linux-doc@...r.kernel.org, linux-fbdev@...r.kernel.org,
	linux-usb@...r.kernel.org, linux-serial@...r.kernel.org,
	rtc-linux@...glegroups.com, devicetree-discuss@...ts.ozlabs.org
Subject: Re: [PATCH 8/8] ARM: vt8500: gpio: Devicetree support for arch-vt8500

On Wednesday 08 August 2012, Stephen Warren wrote:
> I think that's all just:
> 
> module_platform_driver(vt8500_gpio_driver);
> 
> (except that _init uses platform_driver_probe() rather than
> platform_driver_register(), which seems unusual. I guess that explains
> the of_find_matching_node() above too.)

Ah, I totally missed both of these. Using platform_driver_register
is definitely preferred over platform_driver_probe in cases like
this, so using module_platform_driver is the right simplification.

	Arnd
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/