linux-kernel - Re: [PATCH 02/41] TTY: 68328serial, fix compilation

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Wed, 08 Aug 2012 21:33:01 +0200
From:	Jiri Slaby <jslaby@...e.cz>
To:	Alan Cox <alan@...ux.intel.com>
CC:	gregkh@...uxfoundation.org, linux-kernel@...r.kernel.org,
	jirislaby@...il.com
Subject: Re: [PATCH 02/41] TTY: 68328serial, fix compilation

On 08/08/2012 05:24 PM, Alan Cox wrote:
> On Tue,  7 Aug 2012 21:47:27 +0200
> Jiri Slaby <jslaby@...e.cz> wrote:
> 
>> tty_struct->termios is no longer a pointer. This was changed recently
>> by "tty: move the termios object into the tty". But 68328serial was
>> not changed, so we now have a compilation error:
>> 68328serial.c: In function 'change_speed':
>> 68328serial.c:518:22: error: invalid type argument of '->' (have
>> 'struct ktermios') 68328serial.c: In function 'rs_set_ldisc':
>> 68328serial.c:620:31: error: invalid type argument of '->' (have
>> 'struct ktermios') 68328serial.c: In function 'rs_set_termios':
>> 68328serial.c:988:20: error: invalid type argument of '->' (have
>> 'struct ktermios')
>>
>> Fix that now.
>>
>> Signed-off-by: Jiri Slaby <jslaby@...e.cz>
>> Cc: Alan Cox <alan@...ux.intel.com>
> 
> Cool - I couldn't even find a compile chain or config to test this. I'd
> assumed it was broken and really wanted dumping in staging (it still
> looks that way 8))

Heh, I cannot tell if there is any user at all. The only thing I know is
it used to compile cleanly the last time I tried and it became broken
now :).

BTW you perhaps know that, compilers for most arches are at:
ftp.kernel.org/pub/tools/crosstool/files/bin/

regards,
-- 
js
suse labs
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/