linux-kernel - Re: [dm-devel] [PATCH] dm: verity support data device offset (Linux 3.4.7)

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Wed, 08 Aug 2012 22:31:21 +0200
From:	Milan Broz <mbroz@...hat.com>
To:	Mikulas Patocka <mpatocka@...hat.com>
CC:	device-mapper development <dm-devel@...hat.com>,
	Alasdair Kergon <agk@...hat.com>,
	"msb@...gle.com" <msb@...gle.com>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	Will Drewry™ <w@...gle.com>,
	wmiaw@...flix.com
Subject: Re: [dm-devel] [PATCH] dm: verity support data device offset (Linux
 3.4.7)

On 08/08/2012 08:46 PM, Mikulas Patocka wrote:

> The problem with the patch is that it changes interface to the userspace 
> tool. The userspace tool veritysetup already exists in recent cryptsetup 
> package, so we can't change the interface - you should change the patch so 
> that the starting data block is the last argument and the argument is 
> optional - so that it is compatible with the existing userspace too.

yes. Please never change interface without at least increasing target version.

I have to add userspace support as well to veritysetup and we need a way
how to detect that option is supported by running kernel.

Milan
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/