linux-kernel - [PATCH] block: Potential null pointer dereference in pkt_generic

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Message-Id: <1344505130-17757-1-git-send-email-makienko@ispras.ru>
Date:	Thu,  9 Aug 2012 13:38:50 +0400
From:	Marina Makienko <makienko@...ras.ru>
To:	Thomas Maier <balagi@...tmail.de>
Cc:	Marina Makienko <makienko@...ras.ru>,
	Peter Osterlund <petero2@...ia.com>,
	linux-kernel@...r.kernel.org, ldv-project@...ras.ru
Subject: [PATCH] block: Potential null pointer dereference in pkt_generic_packet()

The function blk_get_request() can return NULL. It can lead to further error in pkt_generic_packet().

Found by Linux Driver Verification project (linuxtesting.org).

Signed-off-by: Marina Makienko <makienko@...ras.ru>
---
 drivers/block/pktcdvd.c |    5 +++++
 1 files changed, 5 insertions(+), 0 deletions(-)

diff --git a/drivers/block/pktcdvd.c b/drivers/block/pktcdvd.c
index ba66e44..db3192e 100644
--- a/drivers/block/pktcdvd.c
+++ b/drivers/block/pktcdvd.c
@@ -743,6 +743,11 @@ static int pkt_generic_packet(struct pktcdvd_device *pd, struct packet_command *
 	rq = blk_get_request(q, (cgc->data_direction == CGC_DATA_WRITE) ?
 			     WRITE : READ, __GFP_WAIT);
 
+	if (!rq) {
+		printk(DRIVER_NAME"pkt_generic_packet: blk_get_request failed. \n");
+		return NULL;
+	}
+
 	if (cgc->buflen) {
 		if (blk_rq_map_kern(q, rq, cgc->buffer, cgc->buflen, __GFP_WAIT))
 			goto out;
-- 
1.7.7

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/