| lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
|
Open Source and information security mailing list archives
| ||
|
Message-Id: <201208091155.34573.rjw@sisk.pl> Date: Thu, 9 Aug 2012 11:55:34 +0200 From: "Rafael J. Wysocki" <rjw@...k.pl> To: Thierry Reding <thierry.reding@...onic-design.de> Cc: Chris Ball <cjb@...top.org>, Paul Gortmaker <paul.gortmaker@...driver.com>, linux-mmc@...r.kernel.org, linux-kernel@...r.kernel.org Subject: Re: [PATCH] mmc: sdio: Fix PM_SLEEP related build warnings On Thursday, August 09, 2012, Thierry Reding wrote: > On Thu, Aug 09, 2012 at 11:27:02AM +0200, Rafael J. Wysocki wrote: > > On Thursday, August 09, 2012, Thierry Reding wrote: > > > Power management callbacks defined by SIMPLE_DEV_PM_OPS are only used if > > > the PM_SLEEP Kconfig symbol has been defined. If not, the compiler will > > > complain about them being unused. > > > > > > Signed-off-by: Thierry Reding <thierry.reding@...onic-design.de> > > > > The pm_no_operation() thing is not necessary at all, AFAICT. I'd just > > remove it entirely. :-) > > I don't actually have a setup where I can test suspend/resume with this > driver, but if you say so I can follow up with a patch that removes > pm_no_operation(). It should work because many drivers without proper > PM_SLEEP support do not specify .suspend() nor .resume() callbacks > either. Sure, it should work. Thanks, Rafael -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists