linux-kernel - [PATCH] Input: omap4-keypad: Fix the pm_runtime_get

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Message-ID: <1344510690-13030-1-git-send-email-shubhrajyoti@ti.com>
Date:	Thu, 9 Aug 2012 16:41:30 +0530
From:	Shubhrajyoti D <shubhrajyoti@...com>
To:	<linux-input@...r.kernel.org>
CC:	<linux-kernel@...r.kernel.org>,
	Shubhrajyoti D <shubhrajyoti@...com>
Subject: [PATCH] Input: omap4-keypad: Fix the pm_runtime_get_sync return check

A non-zero on pm_runtime_get_sync shouldnt be considered as an error
it only means that there was another user. Fix the error check to check
for negative values only.

This should fix issues like below
[  917.049713] omap4-keypad omap4-keypad: pm_runtime_get_sync() failed
[  917.056457] omap4-keypad: probe of omap4-keypad failed with error 1

Signed-off-by: Shubhrajyoti D <shubhrajyoti@...com>
---
 drivers/input/keyboard/omap4-keypad.c |    4 ++--
 1 files changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/input/keyboard/omap4-keypad.c b/drivers/input/keyboard/omap4-keypad.c
index 17efede..34cddaf 100644
--- a/drivers/input/keyboard/omap4-keypad.c
+++ b/drivers/input/keyboard/omap4-keypad.c
@@ -305,8 +305,8 @@ static int __devinit omap4_keypad_probe(struct platform_device *pdev)
 	 */
 	pm_runtime_enable(&pdev->dev);
 	error = pm_runtime_get_sync(&pdev->dev);
-	if (error) {
-		dev_err(&pdev->dev, "pm_runtime_get_sync() failed\n");
+	if (IS_ERR_VALUE(error)) {
+		dev_err(&pdev->dev, "pm_runtime_get_sync() failed %d\n", error);
 		goto err_unmap;
 	}
 	rev = __raw_readl(keypad_data->base + OMAP4_KBD_REVISION);
-- 
1.7.5.4

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/