linux-kernel - Re: [GIT PULL for 3.6-rc1] media updates part 2

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Thu, 09 Aug 2012 08:38:04 -0300
From:	Mauro Carvalho Chehab <mchehab@...hat.com>
To:	David Rientjes <rientjes@...gle.com>
CC:	Linus Torvalds <torvalds@...ux-foundation.org>,
	Andrew Morton <akpm@...ux-foundation.org>,
	linux-media@...r.kernel.org, linux-kernel@...r.kernel.org,
	Hans de Goede <hdegoede@...hat.com>
Subject: Re: [GIT PULL for 3.6-rc1] media updates part 2

Em 08-08-2012 19:28, David Rientjes escreveu:
> On Tue, 31 Jul 2012, Mauro Carvalho Chehab wrote:
> 
>>        [media] radio-shark: New driver for the Griffin radioSHARK USB radio receiver
> 
> This one gives me a build warning if CONFIG_LEDS_CLASS is disabled:
> 
> ERROR: "led_classdev_register" [drivers/media/radio/shark2.ko] undefined!
> ERROR: "led_classdev_unregister" [drivers/media/radio/shark2.ko] undefined!
> 

Could you please test the enclosed patch?

Thanks!
Mauro

-

[media] radio-shark: make sure LEDS_CLASS is selected

As reported by David:
	> ERROR: "led_classdev_register" [drivers/media/radio/shark2.ko] undefined!
	> ERROR: "led_classdev_unregister" [drivers/media/radio/shark2.ko] undefined!

Reported-by: Dadiv Rientjes <rientjes@...gle.com>
Cc: Hans de Goede <hdegoede@...hat.com>
Signed-off-by: Mauro Carvalho Chehab <mchehab@...hat.com>


diff --git a/drivers/media/radio/Kconfig b/drivers/media/radio/Kconfig
index 8090b87..be68ec2 100644
--- a/drivers/media/radio/Kconfig
+++ b/drivers/media/radio/Kconfig
@@ -60,6 +60,7 @@ config RADIO_MAXIRADIO
 config RADIO_SHARK
 	tristate "Griffin radioSHARK USB radio receiver"
 	depends on USB && SND
+	select LEDS_CLASS
 	---help---
 	  Choose Y here if you have this radio receiver.
 
@@ -77,6 +78,7 @@ config RADIO_SHARK
 config RADIO_SHARK2
 	tristate "Griffin radioSHARK2 USB radio receiver"
 	depends on USB
+	select LEDS_CLASS
 	---help---
 	  Choose Y here if you have this radio receiver.
 

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/