linux-kernel - Re: [PATCH v2] usb: gadget: composite: parse dt values

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20120809114901.GV12174@arwen.pp.htv.fi>
Date:	Thu, 9 Aug 2012 14:49:02 +0300
From:	Felipe Balbi <balbi@...com>
To:	Sebastian Andrzej Siewior <sebastian@...akpoint.cc>
Cc:	Alexandre Pereira da Silva <aletes.xgr@...il.com>,
	Grant Likely <grant.likely@...retlab.ca>,
	Rob Herring <rob.herring@...xeda.com>,
	Rob Landley <rob@...dley.net>, Felipe Balbi <balbi@...com>,
	Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
	Michal Nazarewicz <mina86@...a86.com>,
	devicetree-discuss@...ts.ozlabs.org, linux-doc@...r.kernel.org,
	linux-kernel@...r.kernel.org, linux-usb@...r.kernel.org
Subject: Re: [PATCH v2] usb: gadget: composite: parse dt values

Hi,

On Thu, Aug 09, 2012 at 01:42:42PM +0200, Sebastian Andrzej Siewior wrote:
> On Tue, Jul 24, 2012 at 10:15:20AM -0300, Alexandre Pereira da Silva wrote:
> > --- /dev/null
> > +++ b/Documentation/devicetree/bindings/usb/gadget.txt
> > @@ -0,0 +1,20 @@
> > +Usb Gadget DeviceTree bindings
> > +
> > +These optional properties inside the usb device controller node are used to
> > +change some of the gadget drivers configuration:
> > +- vendor-id: Usb vendor id
> > +- product-id: Usb product id
> > +- release: Version of this device
> > +- vendor: Textual description of the vendor
> > +- device: Textual description of this device
> > +- serial: Textual representation of the device's serial number
> > +
> > +Binding Example:
> > +	usbd@...20000 {
> > +		vendor-id = <0x0525>;
> > +		product-id = <0xa4a6>;
> > +		release = <1>;
> > +		vendor = "Some Corp";
> > +		device = "Test Device";
> > +		serial = "12345";

on top of everything Sebastian said, I think we should stick to the
field names set forth on the USB specification meaning that instead of
vendor-id we should use idVendor, instead of vendor we should use
iManufacturer, and so on.

-- 
balbi

Download attachment "signature.asc" of type "application/pgp-signature" (837 bytes)