linux-kernel - Re: [GIT PULL for 3.6-rc1] media updates part 2

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Thu, 09 Aug 2012 09:38:18 -0300
From:	Mauro Carvalho Chehab <mchehab@...hat.com>
To:	Hans de Goede <hdegoede@...hat.com>
CC:	David Rientjes <rientjes@...gle.com>,
	Linus Torvalds <torvalds@...ux-foundation.org>,
	Andrew Morton <akpm@...ux-foundation.org>,
	linux-media@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [GIT PULL for 3.6-rc1] media updates part 2

Em 09-08-2012 09:00, Hans de Goede escreveu:
> Hi,
> 
> My bad, sorry about this. Mauro's patch looks good.

Hmm...

menuconfig NEW_LEDS
	bool "LED Support"
	help
	  Say Y to enable Linux LED support.  This allows control of supported
	  LEDs from both userspace and optionally, by kernel events (triggers).

	  This is not related to standard keyboard LEDs which are controlled
	  via the input system.

if NEW_LEDS

config LEDS_CLASS
...


It seems that the patch also need to select or depend on NEW_LEDS.

> An alternative fix
> would be to #ifdefify the led code in the drivers themselves.

Yeah, that would work as well, although the code would look uglier.
IMHO, using select/depend is better.

Regards,
Mauro

> 
> Regards,
> 
> Hans
> 
> 
> On 08/09/2012 01:38 PM, Mauro Carvalho Chehab wrote:
>> Em 08-08-2012 19:28, David Rientjes escreveu:
>>> On Tue, 31 Jul 2012, Mauro Carvalho Chehab wrote:
>>>
>>>>         [media] radio-shark: New driver for the Griffin radioSHARK USB radio receiver
>>>
>>> This one gives me a build warning if CONFIG_LEDS_CLASS is disabled:
>>>
>>> ERROR: "led_classdev_register" [drivers/media/radio/shark2.ko] undefined!
>>> ERROR: "led_classdev_unregister" [drivers/media/radio/shark2.ko] undefined!
>>>
>>
>> Could you please test the enclosed patch?
>>
>> Thanks!
>> Mauro
>>
>> -
>>
>> [media] radio-shark: make sure LEDS_CLASS is selected
>>
>> As reported by David:
>>     > ERROR: "led_classdev_register" [drivers/media/radio/shark2.ko] undefined!
>>     > ERROR: "led_classdev_unregister" [drivers/media/radio/shark2.ko] undefined!
>>
>> Reported-by: Dadiv Rientjes <rientjes@...gle.com>
>> Cc: Hans de Goede <hdegoede@...hat.com>
>> Signed-off-by: Mauro Carvalho Chehab <mchehab@...hat.com>
>>
>>
>> diff --git a/drivers/media/radio/Kconfig b/drivers/media/radio/Kconfig
>> index 8090b87..be68ec2 100644
>> --- a/drivers/media/radio/Kconfig
>> +++ b/drivers/media/radio/Kconfig
>> @@ -60,6 +60,7 @@ config RADIO_MAXIRADIO
>>   config RADIO_SHARK
>>       tristate "Griffin radioSHARK USB radio receiver"
>>       depends on USB && SND
>> +    select LEDS_CLASS
>>       ---help---
>>         Choose Y here if you have this radio receiver.
>>
>> @@ -77,6 +78,7 @@ config RADIO_SHARK
>>   config RADIO_SHARK2
>>       tristate "Griffin radioSHARK2 USB radio receiver"
>>       depends on USB
>> +    select LEDS_CLASS
>>       ---help---
>>         Choose Y here if you have this radio receiver.
>>
>>

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/