[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <5023B2A4.6020808@nvidia.com>
Date: Thu, 9 Aug 2012 18:22:52 +0530
From: Laxman Dewangan <ldewangan@...dia.com>
To: Mark Brown <broonie@...nsource.wolfsonmicro.com>
CC: Stephen Warren <swarren@...dotorg.org>, Liam Girdwood <lrg@...com>,
"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
Gyungoh Yoo <jack.yoo@...im-ic.com>,
Stephen Warren <swarren@...dia.com>
Subject: Re: [PATCH V2 3/3] regulator: add MAX8907 driver
On Thursday 09 August 2012 06:30 PM, Mark Brown wrote:
> On Thu, Aug 09, 2012 at 05:57:03PM +0530, Laxman Dewangan wrote:
>> On Thursday 09 August 2012 06:08 PM, Mark Brown wrote:
>>> The driver should just register all the regulators the chip has, it's
>>> useful for diagnostic purposes if nothing else.
>> Then probably we need to update our dts file becasue we left some of
>> regualtor entry as it is not used on design.
> Why would this impact the device tree?
If entry is not there in dts file then init_data will be null for that
regulator.
I was thinking that if we dont provide the valid init_data at the time
of regulator_registration, it will fail but going through the
regulator_register() in core it seems it is not mandatory to have valid
init_data. So even if we call regulator_register() with init_data=NULL
will be success.
So the checks for the init data is not require here.
I am acking it..
Acked-by: Laxman Dewangan <ldewangan@...dia.com>
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists