lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Thu, 9 Aug 2012 17:55:26 +0400 From: Marina Makienko <makienko@...ras.ru> To: "David S. Miller" <davem@...emloft.net> Cc: Marina Makienko <makienko@...ras.ru>, linux-ide@...r.kernel.org, linux-kernel@...r.kernel.org, ldv-project@...ras.ru Subject: [PATCH 09/13] ide: Potential null pointer dereference in set_multcount() The function blk_get_request() can return NULL in some cases. There are checks on it if function is called with argumetns one of which is GFP_ATOMIC/GFP_NOIO/etc. If system couldn't find request blk_get_request() return NULL. But if there is function call with argument __GFP_WAIT the system will wait until get request or the queue becomes dead. If something kills the queue, blk_get_request() return NULL and next operations will lead to errors. Found by Linux Driver Verification project (linuxtesting.org). Signed-off-by: Marina Makienko <makienko@...ras.ru> --- drivers/ide/ide-disk.c | 4 ++++ 1 files changed, 4 insertions(+), 0 deletions(-) diff --git a/drivers/ide/ide-disk.c b/drivers/ide/ide-disk.c index 16f69be..538d206 100644 --- a/drivers/ide/ide-disk.c +++ b/drivers/ide/ide-disk.c @@ -479,6 +479,10 @@ static int set_multcount(ide_drive_t *drive, int arg) return -EBUSY; rq = blk_get_request(drive->queue, READ, __GFP_WAIT); + if (!rq) { + printk(KERN_ERR PFX"set_multcount: blk_get_request() failed. \n"); + return 1; + } rq->cmd_type = REQ_TYPE_ATA_TASKFILE; drive->mult_req = arg; -- 1.7.7 -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists