linux-kernel - Re: [PATCH 2/2 v2] ALSA: hda - Deferred probing with request_firmware

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20120809140403.GA10145@avionic-0098.mockup.avionic-design.de>
Date:	Thu, 9 Aug 2012 16:04:03 +0200
From:	Thierry Reding <thierry.reding@...onic-design.de>
To:	David Henningsson <david.henningsson@...onical.com>
Cc:	Takashi Iwai <tiwai@...e.de>, alsa-devel@...a-project.org,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH 2/2 v2] ALSA: hda - Deferred probing with
 request_firmware_nowait()

On Thu, Aug 09, 2012 at 03:54:04PM +0200, David Henningsson wrote:
> On 08/09/2012 03:36 PM, Takashi Iwai wrote:
> >+/* callback from request_firmware_nowait() */
> >+static void azx_firmware_cb(const struct firmware *fw, void *context)
> >+{
> >+	struct snd_card *card = context;
> >+	struct azx *chip = card->private_data;
> >+	struct pci_dev *pci = chip->pci;
> >+
> >+	if (!fw) {
> >+		snd_printk(KERN_ERR SFX "Cannot load firmware, aborting\n");
> >+		goto error;
> >+	}
> 
> Another thing, aren't you missing a
> 
> chip->fw = fw;
> 
> here?

Adding that line here fixes the problem for me.

Thierry

Content of type "application/pgp-signature" skipped