linux-kernel - Re: [PATCH v2 6/6] x86: switch the 64bit uncached page clear to SSE/AVX v2

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <5023F3580200007800093F2C@nat28.tlf.novell.com>
Date:	Thu, 09 Aug 2012 16:28:56 +0100
From:	"Jan Beulich" <JBeulich@...e.com>
To:	"Andi Kleen" <ak@...ux.intel.com>,
	"Kirill A. Shutemov" <kirill.shutemov@...ux.intel.com>
Cc:	"Andy Lutomirski" <luto@...capital.net>,
	"Robert Richter" <robert.richter@....com>,
	"Johannes Weiner" <hannes@...xchg.org>,
	"Hugh Dickins" <hughd@...gle.com>, "Alex Shi" <alex.shu@...el.com>,
	"KAMEZAWA Hiroyuki" <kamezawa.hiroyu@...fujitsu.com>,
	<x86@...nel.org>, <linux-mm@...ck.org>,
	"Thomas Gleixner" <tglx@...utronix.de>,
	"Andrew Morton" <akpm@...ux-foundation.org>,
	<linux-mips@...ux-mips.org>,
	"Tim Chen" <tim.c.chen@...ux.intel.com>,
	<linuxppc-dev@...ts.ozlabs.org>,
	"Andrea Arcangeli" <aarcange@...hat.com>,
	"Ingo Molnar" <mingo@...hat.com>, "Mel Gorman" <mgorman@...e.de>,
	<linux-kernel@...r.kernel.org>, <linux-sh@...r.kernel.org>,
	<sparclinux@...r.kernel.org>, "H. Peter Anvin" <hpa@...or.com>
Subject: Re: [PATCH v2 6/6] x86: switch the 64bit uncached page clear
 to SSE/AVX v2

>>> On 09.08.12 at 17:03, "Kirill A. Shutemov" <kirill.shutemov@...ux.intel.com> wrote:
>  ENTRY(clear_page_nocache)
>  	CFI_STARTPROC
> -	xorl   %eax,%eax
> -	movl   $4096/64,%ecx
> +	push   %rdi
> +	call   kernel_fpu_begin
> +	pop    %rdi

You use CFI annotations elsewhere, so why don't you use
pushq_cfi/popq_cfi here?

Jan

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/