linux-kernel - Re: [PATCH] alarmtimer: implement minimum alarm interval for allowing suspend

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <502426FE.5030301@us.ibm.com>
Date:	Thu, 09 Aug 2012 14:09:18 -0700
From:	John Stultz <johnstul@...ibm.com>
To:	Todd Poynor <toddpoynor@...gle.com>
CC:	linux-kernel@...r.kernel.org, linux-pm@...r.kernel.org,
	arve@...roid.com
Subject: Re: [PATCH] alarmtimer: implement minimum alarm interval for allowing
 suspend

On 08/09/2012 02:06 PM, John Stultz wrote:
> On 08/09/2012 12:37 AM, Todd Poynor wrote:
>> @@ -288,9 +293,11 @@ static int alarmtimer_suspend(struct device *dev)
>>       now = rtc_tm_to_ktime(tm);
>>       now = ktime_add(now, min);
>>
>> -    rtc_timer_start(rtc, &rtctimer, now, ktime_set(0, 0));
>> -
>> -    return 0;
>> +    /* Set alarm, if in the past reject suspend briefly to handle */
>> +    ret = rtc_timer_start(rtc, &rtctimer, now, ktime_set(0, 0));
>> +    if (ret < 0)
>> +        __pm_wakeup_event(ws, 1 * MSEC_PER_SEC);
>> +    return ret;
>
> What if something other then -ETIME  is returned from rtc_timer_start?

Bah, sorry, too fast on the trigger there (enlightenment somehow only 
comes with clicking the send button).
I see the wakeup_source will expire after a second and the next suspend 
can try again.

thanks
-john

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/