linux-kernel - Re: [Regression, post-3.5] System suspend broken on the Mackerel board

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <201208092320.23075.rjw@sisk.pl>
Date:	Thu, 9 Aug 2012 23:20:22 +0200
From:	"Rafael J. Wysocki" <rjw@...k.pl>
To:	Paul Mundt <lethal@...ux-sh.org>
Cc:	kuninori.morimoto.gx@...esas.com,
	Magnus Damm <magnus.damm@...il.com>,
	"Linux-sh list" <linux-sh@...r.kernel.org>,
	Linux PM list <linux-pm@...r.kernel.org>,
	LKML <linux-kernel@...r.kernel.org>,
	Kuninori Morimoto <kuninori.morimoto.gx@...il.com>
Subject: Re: [Regression, post-3.5] System suspend broken on the Mackerel board

On Thursday, August 09, 2012, Paul Mundt wrote:
> On Wed, Aug 08, 2012 at 11:23:04AM +0200, Rafael J. Wysocki wrote:
> > On Tuesday, August 07, 2012, Paul Mundt wrote:
> > > On Sun, Aug 05, 2012 at 12:02:43AM +0200, Rafael J. Wysocki wrote:
> > > > On Wednesday, August 01, 2012, Paul Mundt wrote:
> > > > > Turns out we can just collapse the probe/init stuff anyways, so this
> > > > > ought to fix it. I've verified that it fixes Morimoto-san's issue, my
> > > > > expectation is that the mackerel case is likewise getting tripped up but
> > > > > no one bothered implementing any error detecting logic for gpio_request()
> > > > > failing, so it doesn't fail gracefully.
> > > > > 
> > > > > I'll be pushing this out to Linus shortly:
> > > > 
> > > > Thanks, this helped.  Resume works correctly on Mackerel with 3.6-rc1.
> > > > 
> > > > However, I'm now seeing a different problem related to system suspend on that,
> > > > board which is that sh7372_enter_a3sm_common() returns immediately, as though
> > > > at least one of the wakeup signals was permanently asserted.  This hadn't
> > > > happened before your last pull request was merged, so I suspect that one
> > > > of the irqdomain patches might introduce this behavior.
> > > > 
> > > Ok, I'll back off the irqdomain selection until we have a chance to test
> > > it more on the other platforms.
> > 
> > If you mean removing the select from drivers/sh/intc/Kconfig, that alone doesn't
> > help.  Reverting commit 1d6a21b0a672fb29b01ccf397d478e0541e17716
> > (sh: intc: initial irqdomain support.) helps, though.
> > 
> Yeah, I see what happened now. I inadvertently trampled the -EEXIST
> behaviour. I've taken care of it now, so hopefully you'll have better
> luck with -rc2!

I tested your "sh: intc: Handle domain association for sparseirq pre-allocated
vectors" patch in the meantime and it does fix the issue.

Thanks,
Rafael
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/