linux-kernel - Re: [PATCH v5 5/5] perf script: Add event_analyzing_sample.py as a sample for general event handling

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20120809123007.6f3f0a8f@feng-i7>
Date:	Thu, 9 Aug 2012 12:30:07 +0800
From:	Feng Tang <feng.tang@...el.com>
To:	Namhyung Kim <namhyung@...nel.org>
Cc:	Arnaldo Carvalho de Melo <acme@...hat.com>,
	David Ahern <dsahern@...il.com>,
	Peter Zijlstra <peterz@...radead.org>,
	Ingo Molnar <mingo@...e.hu>, <linux-kernel@...r.kernel.org>,
	Robert Richter <robert.richter@....com>,
	Andi Kleen <andi@...stfloor.org>,
	Stephane Eranian <eranian@...gle.com>
Subject: Re: [PATCH v5 5/5] perf script: Add event_analyzing_sample.py as a
 sample for general event handling

Hi Namhyung,

Many thanks for your valuable comments, I'll fold the fixes into an
incremental patch.

On Thu, 9 Aug 2012 10:30:34 +0900
Namhyung Kim <namhyung@...nel.org> wrote:

> On Wed,  8 Aug 2012 17:57:55 +0800, Feng Tang wrote:
> > Currently only trace point events are supported in perf/python script,
> > the first 3 patches of this serie add the support for all types of
> 

> > +con = sqlite3.connect("/dev/shm/perf.db")
> > +con.isolation_level = None
> > +
> > +def trace_begin():
> > +	print "In trace_begin:\n"
> 
> It seems it's not aligned with other statements, and even not needed at
> all. Does it work?

trace_begin() is a must have for a python script, the <print "In trace_begin:\n">
is automatically generated from "perf script -g", I guess its intension is
to help developer debug their own patches. and same for the trace_end().

> > +def print_header(event_name, cpu, secs, nsecs, pid, comm):
> > +	print "%-20s %5u %05u.%09u %8u %-20s " % \
> > +	(event_name, cpu, secs, nsecs, pid, comm),
> 
> It seems this function was not called anywhere.

It is auto-generated too, and you are right, it is not needed at all,
will remove it.

Thanks,
Feng
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/