linux-kernel - Re: [lm-sensors] NULL dereference BUG in sch56xx

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <5024C7EF.7090408@redhat.com>
Date:	Fri, 10 Aug 2012 10:35:59 +0200
From:	Hans de Goede <hdegoede@...hat.com>
To:	Guenter Roeck <linux@...ck-us.net>
CC:	Fengguang Wu <fengguang.wu@...el.com>,
	linux-kernel@...r.kernel.org, lm-sensors@...sensors.org
Subject: Re: [lm-sensors] NULL dereference BUG in sch56xx_init()

Hi,

On 08/09/2012 04:42 PM, Guenter Roeck wrote:
> On Thu, Aug 09, 2012 at 08:55:26PM +0800, Fengguang Wu wrote:
>> Hi Guenter,
>>
>> This commit triggered an oops which can be fixed by the attached diff.
>> Should it be folded into the original one (preferable for me), or be
>> resent as a standalone patch?
>>
> I folded it into the original commit.
>
> Thanks a lot for the test and feedback!

Fengguang, good catch, thanks!

Guenter, 2 remarks:

1) The changing of the type of the address parameter of sch56xx_device_add is
    not necessary
2) A similar change is needed for the f71882fg, there the type of the address
    variable in f71882fg_init() needs to be changed to int too.

Regards,

Hans
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/