linux-kernel - Re: [PATCH 2/2] pwm: core: Fix coding style issues

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Fri, 10 Aug 2012 15:34:46 +0530
From:	Sachin Kamat <sachin.kamat@...aro.org>
To:	Thierry Reding <thierry.reding@...onic-design.de>
Cc:	linux-kernel@...r.kernel.org, patches@...aro.org
Subject: Re: [PATCH 2/2] pwm: core: Fix coding style issues

On 10 August 2012 15:32, Thierry Reding
<thierry.reding@...onic-design.de> wrote:
> On Fri, Aug 10, 2012 at 03:29:08PM +0530, Sachin Kamat wrote:
>> On 10 August 2012 15:25, Thierry Reding
>> <thierry.reding@...onic-design.de> wrote:
>> > On Fri, Aug 10, 2012 at 10:12:10AM +0530, Sachin Kamat wrote:
>> >> Fixes the following:
>> >> WARNING: line over 80 characters
>> >> ERROR: spaces required around that ':' (ctx:VxW)
>> >> WARNING: Prefer pr_warn(... to pr_warning(...
>> >>
>> >> Signed-off-by: Sachin Kamat <sachin.kamat@...aro.org>
>> >> ---
>> >>  drivers/pwm/core.c |    6 +++---
>> >>  1 files changed, 3 insertions(+), 3 deletions(-)
>> >>
>> >> diff --git a/drivers/pwm/core.c b/drivers/pwm/core.c
>> >> index efc20f8..929be13 100644
>> >> --- a/drivers/pwm/core.c
>> >> +++ b/drivers/pwm/core.c
>> >> @@ -130,7 +130,7 @@ static int pwm_device_request(struct pwm_device *pwm, const char *label)
>> >>  }
>> >>
>> >>  static struct pwm_device *of_pwm_simple_xlate(struct pwm_chip *pc,
>> >> -                                           const struct of_phandle_args *args)
>> >> +                                          const struct of_phandle_args *args)
>> >>  {
>> >>       struct pwm_device *pwm;
>> >>
>> >
>> > Can this hunk be removed, please? I think aligning the arguments is more
>> > useful than respecting the 80-columns limit.
>>
>> Sure, if you think so. Anyway it was just one space deleted. Do you
>> want me to re-send the patch?
>
> No, with your permission, I'll just leave that hunk out and remove the
> "WARNING: line over 80 characters" line from the commit message.

OK. That is fine with me.
Thanks.

>
> Thierry



-- 
With warm regards,
Sachin
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/