lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Fri, 10 Aug 2012 14:51:02 +0200 From: Michal Hocko <mhocko@...e.cz> To: Hillf Danton <dhillf@...il.com> Cc: Mel Gorman <mgorman@...e.de>, Andrew Morton <akpm@...ux-foundation.org>, Linux-MM <linux-mm@...ck.org>, LKML <linux-kernel@...r.kernel.org> Subject: Re: [patch] hugetlb: correct page offset index for sharing pmd On Fri 10-08-12 20:37:20, Hillf Danton wrote: > On Fri, Aug 10, 2012 at 8:27 PM, Michal Hocko <mhocko@...e.cz> wrote: > > > > I guess you mean unmap_ref_private and that has been changed by you > > (0c176d5 mm: hugetlb: fix pgoff computation when unmapping page from > > vma)... I was wrong at that time when giving my Reviewed-by. The patch > > didn't break anything because you still find all relevant vmas because > > vma_hugecache_offset just provides a smaller index which is still within > > boundaries. > > No, as shown by the log message of 0c176d52b, that fix was > triggered by (vma->vm_pgoff >> PAGE_SHIFT), thus I dont see > what you really want to revert. fix for that would be a part of the revert of course. > > I think that 0c176d52 should be reverted because we do not have to refer > > to the head page in this case and as we can see it causes confusion. -- Michal Hocko SUSE Labs -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists