linux-kernel - Re: [PATCH 01/15] Proc entry showing inodes on sockfs and types

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20120810155127.3173b904@pyramind.ukuu.org.uk>
Date:	Fri, 10 Aug 2012 15:51:27 +0100
From:	Alan Cox <alan@...rguk.ukuu.org.uk>
To:	Masatake YAMATO <yamato@...hat.com>
Cc:	linux-kernel@...r.kernel.org
Subject: Re: [PATCH 01/15] Proc entry showing inodes on sockfs and types

> +#ifdef CONFIG_PROC_FS
> +	/* Set non-zero value if this protocol manages its
> +	   own /proc/net/PROTOCOL entry and the entry has inode column. */
> +        int has_own_proc_entry;
> +#endif

Is it really worth ifdefs in every file for what is (or should be) a bool
value in the protocol structs of which there are not many

>  };
>  
>  /*
> diff --git a/net/socket.c b/net/socket.c
> index dfe5b66..4044b58 100644
> --- a/net/socket.c
> +++ b/net/socket.c
> @@ -105,6 +105,10 @@
>  #include <linux/sockios.h>
>  #include <linux/atalk.h>
>  
> +#ifdef CONFIG_PROC_FS
> +#include <linux/rwlock_types.h>
> +#endif

You can include it anyway and that makes it easier to avoid bugs

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/