linux-kernel - Re: [PATCH 02/16] perf symbol: remove unused 'end' arg in kallsyms parse cb

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Fri, 10 Aug 2012 10:11:45 -0700
From:	Cody P Schafer <cody@...ux.vnet.ibm.com>
To:	Namhyung Kim <namhyung@...nel.org>
CC:	Arnaldo Carvalho de Melo <acme@...stprotocols.net>,
	LKML <linux-kernel@...r.kernel.org>,
	Ingo Molnar <mingo@...hat.com>,
	Paul Mackerras <paulus@...ba.org>,
	Peter Zijlstra <a.p.zijlstra@...llo.nl>,
	Sukadev Bhattiprolu <sukadev@...ux.vnet.ibm.com>,
	Matt Hellsley <matthltc@...ibm.com>,
	David Hansen <dave@...ux.vnet.ibm.com>
Subject: Re: [PATCH 02/16] perf symbol: remove unused 'end' arg in kallsyms
 parse cb

> I guess that length of 1 effectively same as zero length in this case
> since we end up calling symbols__fixup_end. The 'end - start + 1' part
> looks like a leftover from previous change and not needed anymore -
> KSYM_NAME_LEN check too, IMHO - so I suggest using 0 length to make it
> clear.

Got it.

> And it seems you need to rebase the series onto Arnaldo's current
> perf/core branch which separates out ELF bits to symbol-elf.c.

Will do. It apparently wasn't pushed out when I sent these patches, look 
for v2 shortly.

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/