lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Fri, 10 Aug 2012 11:22:02 +0800 From: Xiao Guangrong <xiaoguangrong@...ux.vnet.ibm.com> To: Marcelo Tosatti <mtosatti@...hat.com> CC: Avi Kivity <avi@...hat.com>, LKML <linux-kernel@...r.kernel.org>, KVM <kvm@...r.kernel.org> Subject: Re: [PATCH v5 03/12] KVM: introduce gfn_to_pfn_memslot_atomic On 08/10/2012 02:50 AM, Marcelo Tosatti wrote: > On Tue, Aug 07, 2012 at 05:49:36PM +0800, Xiao Guangrong wrote: >> It can instead of hva_to_pfn_atomic >> >> Signed-off-by: Xiao Guangrong <xiaoguangrong@...ux.vnet.ibm.com> >> --- >> arch/x86/kvm/mmu.c | 5 +---- >> include/linux/kvm_host.h | 3 ++- >> virt/kvm/kvm_main.c | 14 ++++++++------ >> 3 files changed, 11 insertions(+), 11 deletions(-) > > What if someone needs gfn_to_hva_memslot in the future, which is not > unlikely? Marcelo, We have already had the function gfn_to_hva_memslot in kvm_host.h which is not directly used on x86. In this patchset, gfn_to_hva_memslot does not check the slot->flags. I think we can let it be based on gfn_to_hva_many: static inline unsigned long gfn_to_hva_memslot(struct kvm_memory_slot *slot, gfn_t gfn) { return gfn_to_hva_many(slot, gfn, true); } Then all gfn_to_*() functions are based on gfn_to_hva_many in which we will check slot->flags properly. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists