linux-kernel - Re: [PATCH v3 08/10] IPC: message queue copy feature introduced

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <50265EC9.5020602@parallels.com>
Date:	Sat, 11 Aug 2012 17:31:53 +0400
From:	Stanislav Kinsbursky <skinsbursky@...allels.com>
To:	Manfred Spraul <manfred@...orfullife.com>
CC:	"akpm@...ux-foundation.org" <akpm@...ux-foundation.org>,
	"eparis@...isplace.org" <eparis@...isplace.org>,
	"a.p.zijlstra@...llo.nl" <a.p.zijlstra@...llo.nl>,
	"arnd@...db.de" <arnd@...db.de>,
	"hughd@...gle.com" <hughd@...gle.com>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	"cmetcalf@...era.com" <cmetcalf@...era.com>,
	"yeohc@....ibm.com" <yeohc@....ibm.com>,
	"linux-security-module@...r.kernel.org" 
	<linux-security-module@...r.kernel.org>,
	"viro@...iv.linux.org.uk" <viro@...iv.linux.org.uk>,
	"kosaki.motohiro@...fujitsu.com" <kosaki.motohiro@...fujitsu.com>,
	"hpa@...or.com" <hpa@...or.com>,
	"casey@...aufler-ca.com" <casey@...aufler-ca.com>,
	"sds@...ho.nsa.govjames.l.morris" <sds@...ho.nsa.govjames.l.morris>,
	"devel@...nvz.org" <devel@...nvz.org>
Subject: Re: [PATCH v3 08/10] IPC: message queue copy feature introduced

11.08.2012 15:20, Manfred Spraul пишет:
> Hi Stanislav,
>
> 2012/8/10 Stanislav Kinsbursky <skinsbursky@...allels.com>:
>> This patch is required for checkpoint/restore in userspace.
>> IOW, c/r requires some way to get all pending IPC messages without deleting
>> them from the queue (checkpoint can fail and in this case tasks will be resumed,
>> so queue have to be valid).
>> To achive this, new operation flag MSG_COPY for sys_msgrcv() system call was
>> introduced. Also, copy counter was added to msg_queue structure. It's set to
>> zero by default and increases by one on each copy operation and decreased by
>> one on each receive operation until reaches zero.
> Is msq->q_copy_cnt really necessary?
> As far as I can see user space needs the ability to read the n-th message.
>
> The implementation adds a state variable to the kernel, adds two
> automatic updates of the state into msgrcv() (an increase during
> MSG_COPY, a decrease during normal receives) and adds a msgctl() to
> set the state to a certain value.
>
> a) What about the simpler approach:
> - if MSG_COPY is set, then @mtype is interpreted as the number of the
> message that should be copied.
>    If there are less than @mtype messages, then -ENOMSG is returned.

Hi, Manfred.
Your approach is simplier, but makes the call less generic and adds 
limitations.
I.e. sys_msgrcv() allows you to receive message by type. And from my pow 
this logic have to be preserved - you can specify type and then copy all 
the messages of specified type.

> b) I do not understand the purpose of the decrease of msq->q_copy_cnt:
> Do you want to handle normal msgrcv() calls in parallel with
> msgrcv(|MSG_COPY) calls?

Actually, I'm not going to copy a message from a queue, when somebody is 
reading from it. But better to handle this case by decreasing 
msq->q_copy_cnt, because otherwise this counter becomes invalid in case 
of somebody is reading from queue. And this logic is similar to new 
"peek" logic for sockets (introduced in 3.4 or 3.5).
But I understand, that in case of queue with messages with different 
types this approach works only if mtype is not specified for copy 
operation. Otherwise result is unpredictable.

> I don't think that this will work:
> What if msq->q_copy_cnt is 1 and and msgrcv() call receives the 20th
> message in the queue?

By "receives" you mean "copied"? If so, then it can happen only if mtype 
was specified. And this logic is a part of current implementation.

>
> --
>    Manfred

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/