linux-kernel - Re: [PATCH 14/15] sh: MTU2: Basic runtime PM support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAMuHMdUFeS6HNFuKVDLrFEo0f5=jrufa4QoD+aeZJHJD1Q1xCQ@mail.gmail.com>
Date:	Sat, 11 Aug 2012 11:39:55 +0200
From:	Geert Uytterhoeven <geert@...ux-m68k.org>
To:	"Rafael J. Wysocki" <rjw@...k.pl>
Cc:	Linux PM list <linux-pm@...r.kernel.org>,
	LKML <linux-kernel@...r.kernel.org>,
	Linux-sh list <linux-sh@...r.kernel.org>,
	Magnus Damm <magnus.damm@...il.com>,
	Paul Mundt <lethal@...ux-sh.org>,
	Thomas Gleixner <tglx@...utronix.de>
Subject: Re: [PATCH 14/15] sh: MTU2: Basic runtime PM support

On Mon, Aug 6, 2012 at 1:49 AM, Rafael J. Wysocki <rjw@...k.pl> wrote:
> @@ -341,8 +346,19 @@ static int __devinit sh_mtu2_probe(struc
>         if (ret) {
>                 kfree(p);
>                 platform_set_drvdata(pdev, NULL);
> +               pm_runtime_idle(&pdev->dev);
> +               return ret;
>         }
> -       return ret;
> +       if (is_early_platform_device(pdev))
> +               return 0;
> +
> + out:
> +       if (cfg->clockevent_rating)

drivers/clocksource/sh_mtu2.c:356:6: error: 'cfg' undeclared (first
use in this function)
http://kisskb.ellerman.id.au/kisskb/buildresult/6883515/

Presumably there's a

        struct sh_timer_config *cfg = p->pdev->dev.platform_data;

missing at the top of sh_mtu2_probe()

> +               pm_runtime_irq_safe(&pdev->dev);
> +       else
> +               pm_runtime_idle(&pdev->dev);
> +
> +       return 0;
>  }
>
>  static int __devexit sh_mtu2_remove(struct platform_device *pdev)

Gr{oetje,eeting}s,

                        Geert

--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@...ux-m68k.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/