linux-kernel - Re: [PATCH] be2iscsi: cleanup format strings using literal string concatenations

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <1344791104.3810.2.camel@joe2Laptop>
Date:	Sun, 12 Aug 2012 10:05:04 -0700
From:	Joe Perches <joe@...ches.com>
To:	Masatake YAMATO <yamato@...hat.com>
Cc:	linux-scsi@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] be2iscsi: cleanup format strings using literal string
 concatenations

On Mon, 2012-08-13 at 00:25 +0900, Masatake YAMATO wrote:
> In format strings for printk in be2iscsi, literal c string
> concatenations are used widely. However, the log output is a bit
> difficult to read because whitespaces are missed in the literal c
> strings like:
> 
>     SE_DEBUG(DBG_LVL_1, "CQ Error %d, reset"
> 			"received/sent on CID 0x%x...\n",
> 
> You will see "CQ Error 0xffffffff resetreceived/sent on CID ..." and
> wonder what is "resetreceived".

It'd be even better to coalesce the formats so they'd be
easier to grep.  Just ignore 80 columns.

	SE_DEBUG(DBG_LVL_1,
		 "CQ Error %d, reset received/sent on CID 0x%x...\n",



--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/