lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Sun, 12 Aug 2012 14:42:25 +1200 From: Michael Cree <mcree@...on.net.nz> To: Fengguang Wu <fengguang.wu@...el.com> CC: linux-alpha@...r.kernel.org, Richard Henderson <rth@...ddle.net>, Ivan Kokshaysky <ink@...assic.park.msu.ru>, Matt Turner <mattst88@...il.com>, Tony Luck <tony.luck@...il.com>, James Bottomley <James.Bottomley@...senpartnership.com>, John David Anglin <dave.anglin@...l.net>, Mel Gorman <mgorman@...e.de>, kernel-janitors@...r.kernel.org, Kyle McMartin <kyle@...isc-linux.org>, Andrew Morton <akpm@...ux-foundation.org>, LKML <linux-kernel@...r.kernel.org>, Parisc List <linux-parisc@...r.kernel.org> Subject: Re: [next:akpm 129/309] net/core/sock.c:274:36: error: initializer element is not constant On 12/08/12 14:10, Fengguang Wu wrote: > On Sun, Aug 12, 2012 at 01:33:09PM +1200, Michael Cree wrote: >> On 03/08/12 03:02, Fengguang Wu wrote: >>> On Thu, Jul 26, 2012 at 10:06:41AM -0700, Tony Luck wrote: >>>> On Tue, Jul 24, 2012 at 10:10 PM, James Bottomley >>>> <James.Bottomley@...senpartnership.com> wrote: >>>>>> Here is the line in sock.i: >>>>>> >>>>>> struct static_key memalloc_socks = ((struct static_key) { .enabled = >>>>>> ((atomic_t) { (0) }) }); >>>>> >>>>> The above line contains two compound literals. It also uses a designated >>>>> initializer to initialize the field enabled. A compound literal is not a >>>>> constant expression. >>>> >>>> Seeing the same thing on ia64 building next-20120726. Same fix works >>>> for me ... so I'll steal this whole changelog and attributes. >>> >>> I got the same error for alpha, the same fix applies. >> >> Just trying this patch on Alpha against v3.6-rc1 and it leads to new >> compilation errors, namely: >> >> init/init_task.c:12: error: braced-group within expression allowed only >> inside a function >> init/init_task.c:13: error: braced-group within expression allowed only >> inside a function >> init/init_task.c:16: error: braced-group within expression allowed only >> inside a function >> init/init_task.c:16: error: braced-group within expression allowed only >> inside a function >> make[1]: *** [init/init_task.o] Error 1 > > Sorry! This will actually compile: > > -#define ATOMIC_INIT(i) ( { (i) } ) > +#define ATOMIC_INIT(i) { (i) } Thanks, it now compiles correctly. I'm currently collecting Alpha patches to send on to Linus so will include this one. Cheers Michael. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists