linux-kernel - Re: [PATCH] block: Don't use static to define "void *p" in show_partition

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <5027CFA0.1020207@msgid.tls.msk.ru>
Date:	Sun, 12 Aug 2012 19:45:36 +0400
From:	Michael Tokarev <mjt@....msk.ru>
To:	Jens Axboe <axboe@...nel.dk>
CC:	majianpeng <majianpeng@...il.com>,
	linux-kernel <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] block: Don't use static to define "void *p" in show_partition_start().

On 03.08.2012 12:41, Jens Axboe wrote:
> On 08/03/2012 07:07 AM, majianpeng wrote:
[]
>> diff --git a/block/genhd.c b/block/genhd.c
>> index cac7366..d839723 100644
>> --- a/block/genhd.c
>> +++ b/block/genhd.c
>> @@ -835,7 +835,7 @@ static void disk_seqf_stop(struct seq_file *seqf, void *v)
>>  
>>  static void *show_partition_start(struct seq_file *seqf, loff_t *pos)
>>  {
>> -	static void *p;
>> +	void *p;
>>  
>>  	p = disk_seqf_start(seqf, pos);
>>  	if (!IS_ERR_OR_NULL(p) && !*pos)
> 
> Huh, that looks like a clear bug. I've applied it, thanks.

It also looks like a -stable material, don't you think?

Thanks,

/mjt

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/