linux-kernel - Re: [PATCH 3/7] uprobes: change uprobe_mmap() to ignore the errors but check fatal_signal

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20120813132108.GH31805@linux.vnet.ibm.com>
Date:	Mon, 13 Aug 2012 18:51:08 +0530
From:	Srikar Dronamraju <srikar@...ux.vnet.ibm.com>
To:	Oleg Nesterov <oleg@...hat.com>
Cc:	Ingo Molnar <mingo@...e.hu>, Peter Zijlstra <peterz@...radead.org>,
	Ananth N Mavinakayanahalli <ananth@...ibm.com>,
	Anton Arapov <anton@...hat.com>, linux-kernel@...r.kernel.org
Subject: Re: [PATCH 3/7] uprobes: change uprobe_mmap() to ignore the errors
 but check fatal_signal_pending()

* Oleg Nesterov <oleg@...hat.com> [2012-08-08 19:37:42]:

> Once install_breakpoint() fails uprobe_mmap() "ignores" all other
> uprobes and returns the error.
> 
> It was never really needed to to stop after the first error, and
> in fact it was always wrong at least in -ENOTSUPP case.
> 
> Change uprobe_mmap() to ignore the errors and always return 0.
> This is not what we want in the long term, but until we teach
> the callers to handle the failure it would be better to remove
> the pointless complications. And this doesn't look too bad, the
> only "reasonable" error is ENOMEM but in this case the caller
> should be oom-killed in the likely case or the system has more
> serious problems.
> 
> However it makes sense to stop if fatal_signal_pending() == T.
> In particular this helps if the task was oom-killed.
> 
> Signed-off-by: Oleg Nesterov <oleg@...hat.com>
Acked-by: Srikar Dronamraju <srikar@...ux.vnet.ibm.com>

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/