linux-kernel - Re: [PATCH] perf: Let O= makes handle relative paths

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Mon, 13 Aug 2012 15:24:38 +0200
From:	Borislav Petkov <bp@...64.org>
To:	Steven Rostedt <rostedt@...dmis.org>
Cc:	LKML <linux-kernel@...r.kernel.org>,
	Arnaldo Carvalho de Melo <acme@...radead.org>,
	"borislav.petkov" <borislav.petkov@....com>,
	Ingo Molnar <mingo@...e.hu>,
	Namhyung Kim <namhyung.kim@....com>
Subject: Re: [PATCH] perf: Let O= makes handle relative paths

On Mon, Aug 13, 2012 at 09:20:55AM -0400, Steven Rostedt wrote:
> When I did a compile of perf using a relative path for the output
> directory, the build failed when it tried to compile libtraceevent. This
> is because it continues to use the same relative path when the new
> working directory is in a different path.
> 
>     SUBDIR ../lib/traceevent/
> /bin/sh: line 0: cd: ../../../nobackup/perf/: No such file or directory
> Makefile:74: *** output directory "../../../nobackup/perf/" does not exist.  Stop.
> make: *** [../../../nobackup/perf///libtraceevent.a] Error 2
> 
> 
> Make the path used an absolute path when building perf with O=.
> 
> Signed-off-by: Steven Rostedt <rostedt@...dmis.org>
> 
> diff --git a/tools/scripts/Makefile.include b/tools/scripts/Makefile.include
> index bde8521..9e3e31e 100644
> --- a/tools/scripts/Makefile.include
> +++ b/tools/scripts/Makefile.include
> @@ -1,6 +1,7 @@
>  ifeq ("$(origin O)", "command line")
> -	OUTPUT := $(O)/
> -	COMMAND_O := O=$(O)
> +	RAW_O := $(shell cd $(O) ; pwd)
> +	OUTPUT := $(RAW_O)/
> +	COMMAND_O := O=$(RAW_O)

So wouldn't it make sense to call this ABSOLUTE_O or so then?

Thanks.

-- 
Regards/Gruss,
Boris.

Advanced Micro Devices GmbH
Einsteinring 24, 85609 Dornach
GM: Alberto Bozzo
Reg: Dornach, Landkreis Muenchen
HRB Nr. 43632 WEEE Registernr: 129 19551
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/