linux-kernel - Re: [PATCH 2/2] apple_gmux: Add support for newer hardware

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20120813213607.GB27838@srcf.ucam.org>
Date:	Mon, 13 Aug 2012 22:36:07 +0100
From:	Matthew Garrett <mjg59@...f.ucam.org>
To:	linux-kernel@...r.kernel.org, platform-driver-x86@...r.kernel.org,
	Bernhard Froemel <froemel@...rs.tuwien.ac.at>
Subject: Re: [PATCH 2/2] apple_gmux: Add support for newer hardware

On Mon, Aug 13, 2012 at 04:04:44PM -0500, Seth Forshee wrote:
> > +
> > +	while (i && (gwr & 0x01)) {
> > +		inb(gmux_data->iostart + GMUX_PORT_READ);
> > +		gwr = inb(gmux_data->iostart + GMUX_PORT_WRITE);
> > +		msleep(100);
> 
> Wouldn't it make more sense if the msleep was before reading the port
> again? Otherwise there's no substantial dely between the first and
> second times we read it.

Mm. I'm doing the same as the ACPI implementation - it may be that 
reading GMUX_PORT_READ triggers the update of GMUX_PORT_WRITE? Hard to 
know without the docs.

-- 
Matthew Garrett | mjg59@...f.ucam.org
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/