linux-kernel - Re: [PATCH] drm/radeon: Include swiotlb.h if SWIOTLB configured.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1344841259.4126.4.camel@mattotaupa>
Date:	Mon, 13 Aug 2012 09:00:59 +0200
From:	Paul Menzel <paulepanter@...rs.sourceforge.net>
To:	Huacai Chen <chenhuacai@...il.com>
Cc:	David Airlie <airlied@...ux.ie>,
	Michel Dänzer <michel@...nzer.net>,
	linux-kernel@...r.kernel.org, dri-devel@...ts.freedesktop.org,
	Hongliang Tao <taohl@...ote.com>,
	Fuxin Zhang <zhangfx@...ote.com>,
	Huacai Chen <chenhc@...ote.com>, Hua Yan <yanh@...ote.com>
Subject: Re: [PATCH] drm/radeon: Include swiotlb.h if SWIOTLB configured.

Dear Chen,


thanks for your patch.

Firstly, is Chen your first or last name? If it is your first name, your
From address should be switched.

Am Montag, den 13.08.2012, 10:09 +0800 schrieb Huacai Chen:
> When SWIOTLB is configured, if without this patch kernel compilation
> fails.

Secondly, could you please always paste part of the error message into
the commit message so that people hitting this problem and searching for
it on the WWW have a higher chance finding your patch.

Thirdly, do you know why this was not caught beforehand and compilation
worked before?

> Signed-off-by: Huacai Chen <chenhc@...ote.com>

Lastly, the addresses in your From line and Signed-off-by line disagree.
You can easily fix that, by adding

    From: Huacai Chen <chenhc@...ote.com>

to the beginning of your message.

> Signed-off-by: Hongliang Tao <taohl@...ote.com>
> Signed-off-by: Hua Yan <yanh@...ote.com>
> Cc: dri-devel@...ts.freedesktop.org
> ---
>  drivers/gpu/drm/radeon/radeon_ttm.c |    4 ++++
>  1 files changed, 4 insertions(+), 0 deletions(-)
> 
> diff --git a/drivers/gpu/drm/radeon/radeon_ttm.c b/drivers/gpu/drm/radeon/radeon_ttm.c
> index 5b71c71..fc3ac22 100644
> --- a/drivers/gpu/drm/radeon/radeon_ttm.c
> +++ b/drivers/gpu/drm/radeon/radeon_ttm.c
> @@ -41,6 +41,10 @@
>  #include "radeon_reg.h"
>  #include "radeon.h"
>  
> +#ifdef CONFIG_SWIOTLB
> +#include <linux/swiotlb.h>
> +#endif
> +
>  #define DRM_FILE_PAGE_OFFSET (0x100000000ULL >> PAGE_SHIFT)
>  
>  static int radeon_ttm_debugfs_init(struct radeon_device *rdev);

With the clarification above

    Acked-by: Paul Menzel <paulepanter@...rs.sourceforge.net>

can be added to your patch.


Thanks,

Paul

Download attachment "signature.asc" of type "application/pgp-signature" (199 bytes)